Add Dockerfile #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael1011
requested changes
Jul 7, 2024
There was a problem hiding this comment.
Your image has a size of 4.97GB. Mostly because of compiler artifacts and the Rust compiler toolchain, neither of which are needed in the image.
Something like this:
FROM rust:1.79 AS builder
WORKDIR /app
COPY ./ ./
RUN cargo build --release
FROM debian:bookworm-slim
RUN apt-get update && \
apt-get upgrade && \
apt-get install -y libsqlite3-0 libpq5 && \
apt-get clean all && \
rm -rf /var/lib/apt/lists/*
COPY --from=builder /app/target/release/covclaim /usr/local/bin/covclaim
EXPOSE 1234
CMD ["/usr/local/bin/covclaim"]Has only 93MB. The most important thing is separating the build into two stages, one to compile and one that will become the actual image.
|
And rebase this branch. I just pushed a fix that allows covclaim to start without an |
michael1011
requested changes
Jul 8, 2024
michael1011
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a simple Dockerfile for docker deployments.
Feel free to give suggestions to make it the build quicker or the image smaller